add noqa forwarded import #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scandie
previously approved these changes
Jan 14, 2019
bdmbdsm
requested changes
Jan 17, 2019
openregistry/lots/core/utils.py
Outdated
| @@ -34,6 +34,7 @@ | |||
| get_plugins, # noqa forwarded import | |||
| get_forbidden_users, | |||
| validate_with, # noqa forwarded import | |||
| time_dependent_value, # noqa forwarded import | |||
There was a problem hiding this comment.
Імпортуй без використання zope.deprecation, тобто з utils.common або, ще краще, з utils.timestuff 😃
There was a problem hiding this comment.
@bdmbdsm тоді вже має сенс, переробити всі імпорти)
There was a problem hiding this comment.
Цілком. Але це не є дуже нагально і потрібно, тому можна переробляти по можливості.
oleksiyVeretiuk
force-pushed
the
noqa_forwarder_import
branch
from
3e99221
to
a735d21
Compare
bdmbdsm
approved these changes
Jan 17, 2019
leits
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depending on openprocurement/openprocurement.api#421