Related processes structure #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksiyVeretiuk
changed the title
oleksiyVeretiuk
force-pushed
the
relatedProcessed_structure
branch
from
53a8a5f
to
d1e3cdf
Compare
leits
reviewed
Aug 9, 2018
openregistry/lots/loki/models.py
Outdated
| (Allow, 'g:concierge', 'upload_lot_auctions'), | ||
| (Allow, 'g:concierge', 'upload_lot_related_processes'), |
There was a problem hiding this comment.
Зміна чи створення об'єкту - не upload
leits
reviewed
Aug 13, 2018
| @@ -206,9 +226,10 @@ class Options: | |||
| items = ListType(ModelType(Item), default=list(), validators=[validate_items_uniq]) | |||
| documents = ListType(ModelType(LotDocument), default=list()) | |||
| decisions = ListType(ModelType(LotDecision), default=list(), validators=[validate_decision_uniq]) | |||
| assets = ListType(MD5Type(), required=True, min_size=1, max_size=1) | |||
| relatedProcesses = ListType(ModelType(RelatedProcess), default=list(), max_size=1) | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
leits
reviewed
Aug 16, 2018
openregistry/lots/loki/migration.py
Outdated
| registry.db.update(docs) | ||
|
|
||
|
|
||
| def migrate_assets_to_related_processes(lot, internal_type, registry): |
There was a problem hiding this comment.
Ця умова повинна перевірятися ще до отримання моделі
| self.assertEqual(response.json['data']['status'], 'composing') | ||
|
|
||
| response = self.app.get('/{}'.format(self.resource_id)) | ||
| self.assertEqual(response.json['data']['status'], 'composing') |
There was a problem hiding this comment.
Це пройтися get-ом по relatedProcesses
|
|
||
| @oplotsresource(name='loki:Lot Related Processes', | ||
| collection_path='/lots/{lot_id}/related-processes', | ||
| path='/lots/{lot_id}/related-processes/{relatedProcess_id}', |
There was a problem hiding this comment.
related-processes -> related_processes
leits
approved these changes
Aug 16, 2018
Pull Request Test Coverage Report for Build 274
💛 - Coveralls |
leits
approved these changes
Aug 17, 2018
leits
approved these changes
Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on openprocurement/openprocurement.api#371 openprocurement/openregistry.lots.core#64
openprocurement/openregistry.lots.core#66