Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pyramidtiming middleware #3

Merged
merged 4 commits into from
Jun 13, 2017
Merged

Conversation

VDigitall
Copy link
Member

No description provided.

@VDigitall VDigitall requested a review from kroman0 June 2, 2017 12:52
@VDigitall VDigitall force-pushed the master branch 2 times, most recently from 63912f1 to 38223eb Compare June 6, 2017 08:25
@VDigitall VDigitall requested review from vmaksymiv and leits and removed request for kroman0 June 6, 2017 08:28
raise
else:
delta = time.time() - start
if 200 <= response.status_code < 300:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я б тут написав трошки менше коду
range_code = '{}xx'.format(response.status_code/100)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Але то не обов'язково

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Поправив

setup.py Outdated
]

requires = [
'setuptools',
'pyramid',
] + test_requires
'flask',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вимагаєш завжди мати pyramid i flask ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Може extra requires використати?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6c4f9af on VDigitall:master into 1c67dd8 on openprocurement:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling afa029a on VDigitall:master into 1c67dd8 on openprocurement:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4b264e3 on VDigitall:master into 1c67dd8 on openprocurement:master.

@ktarasz ktarasz merged commit 1dd6ca0 into openprocurement:master Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants