Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.3 cleanup #170

Merged
merged 3 commits into from
Apr 6, 2024
Merged

Release 0.3 cleanup #170

merged 3 commits into from
Apr 6, 2024

Conversation

EthanHeilman
Copy link
Member

@EthanHeilman EthanHeilman commented Apr 5, 2024

This PR performs three cleanup needed for release 0.3.

  1. Solves the inconsistent naming of boolean flag for turning on GQ Signing. In some places we say SignGQ in other places we say GQSign. We rename such flags to GQSIgn. Fixes: SignGQ and GQSign Confusion #168
  2. Renames renames the function which verifies an ID Token from .VerifyProvider(...) to VerifyIDToken(...). I'm normally against renames like this but given that the name of the struct is ProviderVerifier having the function be ProviderVerifier.VerifyProvider(...) costs me 10 minutes doing the wrong thing too many times. Given that the function for verifying a PK Token is VerifyPKToken(...) it seems nature that the function for verifying an ID Token would be VerifyIDToken(...).
  3. Deletes unused compatibility function. Release 0.3 will have many breaking changes, it is time to retire client.VerifyPKToken(...) and just use verifier.VerifyPKToken(...)

Tests

mfa cosigner test

@EthanHeilman EthanHeilman self-assigned this Apr 5, 2024
@EthanHeilman EthanHeilman marked this pull request as ready for review April 5, 2024 17:55
Copy link
Member

@mrjoelkamp mrjoelkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EthanHeilman EthanHeilman merged commit 57897d7 into openpubkey:main Apr 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SignGQ and GQSign Confusion
2 participants