Run unit tests against ISO/IEC 14888-2:2008 GQ test vectors #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EthanHeilman
approved these changes
Dec 13, 2023
jonnystoten
requested changes
Dec 13, 2023
johncmerfeld
force-pushed
the
gq-test-vector
branch
from
bd50571
to
0098773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69
Adds specific signer/verifier tests against the values laid out in the ISO standard on which our implementation is based.
There is one painful difference between the standard and our implementation. It uses SHA-1 instead of SHAKE-256 as a hash function and uses PSS instead of PKCS15 as an encoding / format mechanism. I considered making our solution fully plug-and-play with regard to these functions. However, this incurs a huge code complexity expense because the functions in question do not share the same interface in the go standard library. Instead, I opted to turn the relevant functions into
varsand rewire them at test time. This requires moving the tests from a dedicatedgq_testpackage to thegqpackage.The above is all somewhat messy and I am open to discussing alternatives. However, I believe it is the cleanest way of achieving this test coverage. The good news is that our implementation was correct on the first attempt with no modifications needed.