Add JKT unprotected header to PK token #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnystoten
approved these changes
Dec 8, 2023
EthanHeilman
approved these changes
Dec 8, 2023
jonnystoten
approved these changes
Dec 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per OIDC spec,
kidisn't always present in ID tokens, and if present, is only guaranteed to be unique within a given key set.Verifiers need to be able to look Op public keys in reliable way.
This PR adds a thumbprint calculated in line with RFC-7638 JSON Web Key (JWK) Thumbprint and adds it as an unprotected header called
jktto the Op Signature in the JSON serialization of the PK Token using a new methodPKToken.AddJKTHeaderAfter review:
Resolves #61