Add support for ANTLR 4.12 in openqasm3 package
#453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no actual code changes, this just causes our automated build process to generate the required files to support the ANTLR runtime at version 4.12 as well.
blakejohnson
approved these changes
May 9, 2023
stevenheidel
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are no actual code changes, this just causes our automated build process to generate the required files to support the ANTLR runtime at version 4.12 as well.
Details and comments
Next time we release the
openqasm3package on PyPI, this change will propagate through. We have CD automation to handle the multiple-ANTLR-version generation, and the package does a dynamic import of the relevant ANTLR parser files depending on what version of the runtime we have available at runtime.