Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting in switch section, add extra example #499

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Fix formatting in switch section, add extra example #499

merged 2 commits into from
Dec 20, 2023

Conversation

braised-babbage
Copy link
Contributor

@braised-babbage braised-babbage commented Dec 12, 2023 •
edited
Loading

This does two things:

  • it fixes some small formatting issues in the recently added section on switch statements
  • it adds an extra example in which the switch cases use a const expression

@braised-babbage braised-babbage changed the title Fix formatting in switch section Fix formatting in switch section, add extra example Dec 12, 2023
braised-babbage
braised-babbage commented Dec 12, 2023
View reviewed changes
source/language/classical.rst
@@ -540,8 +566,9 @@ Examples:
case 0b11 {
// OpenQASM3 statement(s)
}
}```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backticks here were a typo.

@braised-babbage braised-babbage mentioned this pull request Dec 12, 2023
Merged
jakelishman
jakelishman approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and the additional example would for sure makes the intention clearer.

@blakejohnson blakejohnson merged commit 0442aad into openqasm:main Dec 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakejohnson blakejohnson blakejohnson approved these changes

@jakelishman jakelishman jakelishman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@braised-babbage @blakejohnson @jakelishman