Update Python versions and dependencies in AST GitHub Actions #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This normalise the AST action to only run the style and lint checks once, on the newest Python version, so that differences between the linters and formatters that might arise from bugfixes not backported to the last supported package version for the oldest Python do not cause spurious failures between the two branches. This notably happened with `black`, where the latest version compatible with Python 3.7 did not contain a bugfix that later versions did have access to. Further, this updates the latest supported version of Python to 3.12, which matches reality, since previously we had left it at 3.10.
|
The docs-build failure in this PR is fixed by #502. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This normalise the AST action to only run the style and lint checks once, on the newest Python version, so that differences between the linters and formatters that might arise from bugfixes not backported to the last supported package version for the oldest Python do not cause spurious failures between the two branches. This notably happened with
black, where the latest version compatible with Python 3.7 did not contain a bugfix that later versions did have access to.Further, this updates the latest supported version of Python to 3.12, which matches reality, since previously we had left it at 3.10.
Details and comments