Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supported_versions to openqasm3.spec. #513

Conversation

hodgestar
Copy link
Contributor

Summary

List the supported specification versions in the openqasm3 package.

Details and comments

In #508 and the following OpenQASM TSC meeting it was discussed that the openqasm3 Python package version would be separate from that of the specification and that the package would support multiple specification versions. Thus it would be useful to list somewhere in the openqasm3 package which versions of the specification are supported.

I considered adding a simple SpecVersion class, but I wasn't sure it was worth the (small) amount of complexity. A comparable specification version might be useful, but in the AST rather than this list of versions (e.g. so that users of the AST could check whether a version was > SpecVersion(3, 1)).

I'm happy to add a SpecVersion class and also use it in the AST, but I thought I'd start with this simpler implementation.

Checklist

✅ I have added the tests to cover my changes.
✅ I have updated the documentation accordingly.
✅ I have read the CONTRIBUTING document.

@mbhealy mbhealy mentioned this pull request Feb 16, 2024
blakejohnson
blakejohnson previously approved these changes Feb 19, 2024
Copy link
Contributor

@blakejohnson blakejohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all in favor of simplicity until something more is needed. So, I am good with this approach.

@blakejohnson
Copy link
Contributor

It does look like you need to add a release note.

@hodgestar
Copy link
Contributor Author

Thanks @blakejohnson. Release note added.

@jlapeyre jlapeyre merged commit 52737c9 into openqasm:main Feb 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants