Correct integer division in pow modifiers
#529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These would have been evaluted to the integer `0` instead of the intended floating-point value `0.5`.
hodgestar
previously approved these changes
Apr 17, 2024
|
I would also be happy with Lev's (I think) suggestion of just writing |
|
Me too - I actually wrote this PR before Lev made that issue, but after I had to run off very quickly at the end of the TSC meeting I didn't have time to push it. Happy to switch to whichever. |
|
I'll put in a +0.5 for switching to |
hodgestar
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These would have been evaluted to the integer
0instead of the intended floating-point value0.5.Details and comments
Fix #528