Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for lowering OpenQASM 3 arithmetic/math expressions to MLIR #263

Merged
merged 25 commits into from Mar 17, 2024

Conversation

taalexander
Copy link
Collaborator

Adds support for:

  • addition (*, *=) for integers and floats
  • subtraction (*, *=) for integers and floats
  • multiplication (*, *=) for integers and floats
  • division (*, *=) for integers and floats
  • modulo (*, *=) for integers and floats
  • power (**) for integers and floats
  • cos() for floats
  • sin() for floats
  • tan() for floats
  • atan() for floats
  • exp() for floats
  • ln() for floats
  • sqrt() for floats

@taalexander taalexander requested a review from a team as a code owner February 21, 2024 02:27
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/Frontend/OpenQASM3/QUIRGenQASM3Visitor.h Outdated Show resolved Hide resolved
SooluThomas
SooluThomas previously approved these changes Mar 12, 2024
Copy link
Contributor

@SooluThomas SooluThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taalexander taalexander merged commit 00ee5a5 into openqasm:main Mar 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants