New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for lowering OpenQASM 3 arithmetic/math expressions to MLIR #263
Merged
taalexander
merged 25 commits into
openqasm:main
from
taalexander:add-qasm3-arith-math-ops
Mar 17, 2024
Merged
Add support for lowering OpenQASM 3 arithmetic/math expressions to MLIR #263
taalexander
merged 25 commits into
openqasm:main
from
taalexander:add-qasm3-arith-math-ops
Mar 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
taalexander
force-pushed
the
add-qasm3-arith-math-ops
branch
from
February 21, 2024 15:15
173464f
to
95da68c
Compare
SooluThomas
previously approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
taalexander
force-pushed
the
add-qasm3-arith-math-ops
branch
from
March 16, 2024 13:05
f7bd2b1
to
b4e33d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for: