Implement a PayloadRegister as a factory to register and create Payloads
#68
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
jgsogo
changed the title
PayloadRegister as a factory to register and create PayloadsPayloadRegister as a factory to register and create Payloads
| qssc::payload::registry::PayloadRegistry::registeredPlugins()) { | ||
| os << target.second.getName() << " - " << target.second.getDescription() | ||
| << "\n"; | ||
| } |
There was a problem hiding this comment.
I'm listing here the available payloads, although there is no CLI argument to select one or another (currently there is only one: ZIP). If we agree on the argument name, I can add it to this PR, or we can wait until we have more payloads registered and there is an actual use case for this argument.
There was a problem hiding this comment.
I suggest adding the argument to this PR, for completeness. We have a similar arg for listing targets:
[$] ./bin/qss-compiler --show-targets
Registered Targets:
--mock - Mock system for testing the targetting infrastructure.
show-payloads seems appropriate. (Feel free also to correct the spelling of 'targeting'. :)
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Approving from my side.
Pinging @mhillenbrand one more, and @mbhealy time to take a look.
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Friendly reminder, @mhillenbrand @mbhealy |
|
For some reason GitHub is not allowing me to add my one comment to the file: |
1 similar comment
|
For some reason GitHub is not allowing me to add my one comment to the file: |
Co-authored-by: Marius Hillenbrand <marius.hillenbrand@ibm.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
This PR implements a
PayloadRegistryfactory as a template specialization ofplugin::registry::PluginRegistry<T>(see #63). This registry can instantiatePayloadInfoitems which, in turn, are responsible of instantiate concretePayloadimplementations (same schema asTargetSystem).It also turns the
ZipPayloadinto a pluggablePayloadfor this new registry.