NSIS packaging error

[forcecore]

I'm using NSIS2 package from AUR, on Arch Linux:

$ bash packaging/package-all.sh r015 tmp
Building Windows package
Building core files
/bin/sh: mods/yupgi_alert/mod.yaml.tmp: No such file or directory
make: *** [Makefile:72: version] Error 1
Installing OpenRA engine to /home/arch/mod/SDK/packaging/windows/build
Installing OpenRA common mod files to /home/arch/mod/SDK/packaging/windows/build
Compiling Windows launcher
Building Windows setup.exe
CreateShortCut expects 2-8 parameters, got 10.
Usage: CreateShortCut shortcut_name.lnk shortcut_target [parameters [icon_file [icon index [showmode [hotkey [comment]]]]]]
showmode=(SW_SHOWNORMAL|SW_SHOWMAXIMIZED|SW_SHOWMINIMIZED)
hotkey=(ALT|CONTROL|EXT|SHIFT)|(F1-F24|A-Z)
Error in script "buildpackage.nsi" on line 103 -- aborting creation process
Windows package build failed.
Package build done.

• I have no idea where /bin/sh: mods/yupgi_alert/mod.yaml.tmp: No such file or directory is coming from. Is it safe to ignore?

[phrohdoh]

$OUTDIR${PACKAGING_WINDOWS_LAUNCHER_NAME}.exe

That probably wants to be wrapped in quotes.

[pchote]

we should also include a comment in mod.config recommending modders to not use spaces in PACKAGING_WINDOWS_LAUNCHER_NAME. Even if we technically allow it, it is bad practice to have spaces in exe names.

[forcecore]

That fixed NSIS error! (removed spaces from name).
Still, I'm not sure where mod.yaml.tmp: No such file or directory this one is coming from.

[pchote]

That sounds like a bug. I'll look into it when I have some time if someone else doesn't beat me to it.

[phrohdoh]

Something failed when running make version.

https://github.com/OpenRA/OpenRAModSDK/blob/master/Makefile?utf8=%E2%9C%93#L71-L75

[forcecore]

Maybe because I soft linked my mod into mods/yupgi_alert? Not too sure.
I'd move on to real files because I don't want all the git and asset development files to go into NSIS installer.

[forcecore]

Moved to real files and it seems to be working without errors.

bash packaging/package-all.sh r015 pwd
Building Windows package
Building core files
make[1]: Entering directory '/home/arch/mod/SDK'
Version changed to r015.
make[1]: Leaving directory '/home/arch/mod/SDK'
make[1]: Entering directory '/home/arch/mod/OpenRA'
make[1]: Leaving directory '/home/arch/mod/OpenRA'
make[1]: Entering directory '/home/arch/mod/OpenRA'
make[1]: Leaving directory '/home/arch/mod/OpenRA'
make[1]: Entering directory '/home/arch/mod/OpenRA'
Installing OpenRA engine to /home/arch/mod/SDK/packaging/windows/build
make[1]: Leaving directory '/home/arch/mod/OpenRA'
make[1]: Entering directory '/home/arch/mod/OpenRA'
Installing OpenRA common mod files to /home/arch/mod/SDK/packaging/windows/build
make[1]: Leaving directory '/home/arch/mod/OpenRA'
Compiling Windows launcher
Building Windows setup.exe
Package build done.

[pchote]

Fixed by 42a8329.