Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review property visibility for all classes. #10

Closed
ghost opened this issue Jun 29, 2018 · 1 comment
Closed

Review property visibility for all classes. #10

ghost opened this issue Jun 29, 2018 · 1 comment

Comments

@ghost
Copy link

ghost commented Jun 29, 2018

This will need to be checked because during development this was not sufficiently taken into account (and I personally feel still insecure how to use visibility correctly).

@ghost
Copy link
Author

ghost commented Jul 28, 2018

Visibility is set to private everywhere except for $u_action which needs to be public. This could still be subject of a refactoring, but this would then better happen in a new issue/pr. Closing as no longer needed for the initial release.

@ghost ghost closed this as completed Jul 28, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants