Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: time_interpolation #117

Merged
merged 2 commits into from Jun 14, 2023

Conversation

kmuehlbauer
Copy link
Collaborator

  • Tests added
  • Changes are documented in history.md

As reported by @egouden in #114 there are issues with time interpolation in some corner cases. While adding a test for this I've found there are more things involved which need changing. This PR addresses (hopefully) all of this.

  • only interpolate of NaT present
  • handle NaT correctly (-9223372036854775808)
  • handle a1gate properly (roll data to first measured ray)
  • derive interpolation angles using diff
  • handle wrap around angles for PPI
  • fix spurious digits introduced by floating point interpolation

Supersedes #114

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #117 (98dfdbf) into main (6fe2ea0) will increase coverage by 0.09%.
The diff coverage is 89.09%.

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   88.08%   88.17%   +0.09%     
==========================================
  Files          19       19              
  Lines        3297     3333      +36     
==========================================
+ Hits         2904     2939      +35     
- Misses        393      394       +1     
Flag Coverage Δ
unittests 88.17% <89.09%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xradar/io/backends/cfradial1.py 86.39% <0.00%> (ø)
xradar/io/backends/furuno.py 91.41% <0.00%> (ø)
xradar/io/backends/iris.py 84.85% <0.00%> (ø)
xradar/io/backends/odim.py 84.98% <0.00%> (ø)
xradar/io/backends/rainbow.py 92.10% <66.66%> (-0.21%) ⬇️
xradar/util.py 97.27% <97.77%> (+0.78%) ⬆️
xradar/io/backends/gamic.py 86.16% <100.00%> (ø)
xradar/model.py 96.19% <100.00%> (+0.02%) ⬆️

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @kmuehlbauer - thanks for catching this/dealing with this!

@kmuehlbauer kmuehlbauer merged commit e464ac7 into openradar:main Jun 14, 2023
12 checks passed
@kmuehlbauer
Copy link
Collaborator Author

OK, let's get this in then.

@kmuehlbauer kmuehlbauer deleted the fix-time-interpolation branch June 14, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants