Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: use datastore._group instead of variable["sweep_number"] #123

Merged
merged 3 commits into from Aug 30, 2023

Conversation

kmuehlbauer
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #123 (2670a5e) into main (1e09e4f) will decrease coverage by 0.03%.
Report is 2 commits behind head on main.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   88.18%   88.15%   -0.03%     
==========================================
  Files          19       19              
  Lines        3335     3336       +1     
==========================================
  Hits         2941     2941              
- Misses        394      395       +1     
Flag Coverage Δ
unittests 88.15% <85.71%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
xradar/io/backends/iris.py 84.77% <66.66%> (-0.09%) ⬇️
xradar/io/export/odim.py 96.77% <100.00%> (ø)

@kmuehlbauer
Copy link
Collaborator Author

@aladinor The approach here reads empty/corrupted sweep from your file and also displays a warning message.

@aladinor
Copy link
Contributor

Thanks @kmuehlbauer for your help!

@kmuehlbauer kmuehlbauer merged commit 2176a6e into openradar:main Aug 30, 2023
10 of 12 checks passed
@kmuehlbauer kmuehlbauer deleted the fix-corrupt-iris-sweep branch August 30, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'sweep_data' when opening sigmet file
2 participants