Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data model + CfRadial1 Backend #13

Merged
merged 19 commits into from Sep 13, 2022
Merged

Conversation

kmuehlbauer
Copy link
Collaborator

First code porting from wradlib:

  • data model
  • CfRadial1 Backend

There is a first import from CfRadial1 into the DataTree.

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @kmuehlbauer ! The only suggestion I would have is to add a test for the cfradial io.

@kmuehlbauer
Copy link
Collaborator Author

@mgrover1 Do we have a cfradial1 file somewhere? I have one inside wradlib-data repo. But that would be overkill. Shall we create a xradar-data repo where we host our testfiles?

@mgrover1
Copy link
Collaborator

@kmuehlbauer - great question. I think a more general open-radar-data repo would be great. This way, we can share across repositories and such.

@mgrover1
Copy link
Collaborator

I also do not see an issue in using one of the wradlib-data files, or one of the Py-ART ones used here

@kmuehlbauer
Copy link
Collaborator Author

I'll just fetch the one file from wradlib-data repo and see how it goes. For CI no problem since we need internet connection anyway.

@kmuehlbauer
Copy link
Collaborator Author

@mgrover1 I've added two tests, one for open_cfradial_datatree and one for xr.open_dataset. Added fixture to grab the cfradial1 file from wradlib-data repo.

This just works with the minimal required data. We would need to enhance this to also make optional attributes and variables available.

@kmuehlbauer kmuehlbauer changed the title WIP: Data model + CfRadial1 Backend Data model + CfRadial1 Backend Sep 13, 2022
@kmuehlbauer
Copy link
Collaborator Author

@mgrover1 This is good to go from my end. There is still much to do, though.

@mgrover1 mgrover1 merged commit 57aa962 into openradar:main Sep 13, 2022
@kmuehlbauer kmuehlbauer mentioned this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants