New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data model + CfRadial1 Backend #13
Conversation
b7b7080
to
b37a8af
Compare
2753412
to
ab9407d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @kmuehlbauer ! The only suggestion I would have is to add a test for the cfradial io.
@mgrover1 Do we have a cfradial1 file somewhere? I have one inside wradlib-data repo. But that would be overkill. Shall we create a xradar-data repo where we host our testfiles? |
@kmuehlbauer - great question. I think a more general open-radar-data repo would be great. This way, we can share across repositories and such. |
I also do not see an issue in using one of the wradlib-data files, or one of the Py-ART ones used here |
I'll just fetch the one file from wradlib-data repo and see how it goes. For CI no problem since we need internet connection anyway. |
@mgrover1 I've added two tests, one for open_cfradial_datatree and one for xr.open_dataset. Added fixture to grab the cfradial1 file from wradlib-data repo. This just works with the minimal required data. We would need to enhance this to also make optional attributes and variables available. |
@mgrover1 This is good to go from my end. There is still much to do, though. |
First code porting from wradlib:
There is a first import from CfRadial1 into the DataTree.