FIX: use len(unique) to estimate unique entry #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 22, 2024 12:36
…en gates (either by manually setting the radar to have varying steps or by small float inaccuracies) causes the reading of a ODIM h5 file to crash. More info on this in issue openradar#150.
|
Thanks @martinpaule, I'll fix the linter/style errors in another PR. Just hang on a bit. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
=======================================
Coverage 88.33% 88.33%
=======================================
Files 20 20
Lines 3439 3439
=======================================
Hits 3038 3038
Misses 401 401
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kmuehlbauer
changed the title
|
@martinpaule Looking good to me. Nothing to add for this simple fix. Are you OK being mentioned in history.md? If so I'd merge this now and get a bug-fix release out in direct course. |
kmuehlbauer
approved these changes
Feb 22, 2024
|
@kmuehlbauer Of course, feel free to mention me in history.md. Thank You for all Your communications :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed an issue in model.py, where having multiple distances between gates (either by manually setting the radar to have varying steps or by small float inaccuracies) causes the reading of a ODIM h5 file to crash, as the "if unique" can't resolve the condition for a multiple-element array.
More details on this in issue #150.