New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add odim exporter, add roundtrip test, add minimal documentation #39
Conversation
Codecov Report
@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 84.57% 85.49% +0.92%
==========================================
Files 14 15 +1
Lines 2884 3005 +121
==========================================
+ Hits 2439 2569 +130
+ Misses 445 436 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@kmuehlbauer just let me know when this is ready for review |
@mgrover1 I think it is read for a first review. I've stripped this to a minimum. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment - otherwise, this looks great! Can we add some sample odim_h5 data to that radar data repo? And use it here as a verification of standards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small linting error
Finally, had some old versions of isort/black in my environment. Should work now. |
Imagine a life without Cloud CI ... 😬 |
No description provided.