Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add odim exporter, add roundtrip test, add minimal documentation #39

Merged
merged 8 commits into from Oct 10, 2022

Conversation

kmuehlbauer
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Merging #39 (ff376f8) into main (4ae6554) will increase coverage by 0.92%.
The diff coverage is 95.12%.

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   84.57%   85.49%   +0.92%     
==========================================
  Files          14       15       +1     
  Lines        2884     3005     +121     
==========================================
+ Hits         2439     2569     +130     
+ Misses        445      436       -9     
Flag Coverage Δ
unittests 85.49% <95.12%> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xradar/io/backends/iris.py 81.58% <ø> (ø)
xradar/io/export.py 95.04% <95.04%> (ø)
xradar/io/__init__.py 100.00% <100.00%> (ø)
xradar/io/backends/common.py 89.28% <100.00%> (+1.34%) ⬆️
xradar/io/backends/odim.py 87.92% <0.00%> (+3.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mgrover1
Copy link
Collaborator

mgrover1 commented Oct 4, 2022

@kmuehlbauer just let me know when this is ready for review

@kmuehlbauer
Copy link
Collaborator Author

@mgrover1 I think it is read for a first review. I've stripped this to a minimum.

Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment - otherwise, this looks great! Can we add some sample odim_h5 data to that radar data repo? And use it here as a verification of standards?

xradar/io/export.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small linting error

@kmuehlbauer
Copy link
Collaborator Author

Finally, had some old versions of isort/black in my environment. Should work now.

@kmuehlbauer
Copy link
Collaborator Author

Imagine a life without Cloud CI ... 😬

@kmuehlbauer kmuehlbauer merged commit 28ab806 into openradar:main Oct 10, 2022
@kmuehlbauer kmuehlbauer deleted the to_odim branch October 10, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants