Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: fetch radar data from open-radar-data, add description/url #44

Merged
merged 3 commits into from Nov 11, 2022

Conversation

kmuehlbauer
Copy link
Collaborator

@kmuehlbauer kmuehlbauer commented Nov 10, 2022

  • fetch radar data from open-radar-data
  • add description/url to BackendEntrypoints
  • test notebooks, fixup CI

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #44 (a0c191b) into main (28ab806) will increase coverage by 0.00%.
The diff coverage is 81.25%.

@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   85.49%   85.49%           
=======================================
  Files          15       15           
  Lines        3005     3020   +15     
=======================================
+ Hits         2569     2582   +13     
- Misses        436      438    +2     
Flag Coverage Δ
unittests 85.49% <81.25%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xradar/accessors.py 39.13% <25.00%> (-0.87%) ⬇️
xradar/io/backends/cfradial1.py 82.22% <100.00%> (+0.40%) ⬆️
xradar/io/backends/furuno.py 90.27% <100.00%> (+0.05%) ⬆️
xradar/io/backends/gamic.py 86.61% <100.00%> (+0.10%) ⬆️
xradar/io/backends/iris.py 81.61% <100.00%> (+0.03%) ⬆️
xradar/io/backends/odim.py 87.98% <100.00%> (+0.05%) ⬆️
xradar/io/backends/rainbow.py 82.80% <100.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kmuehlbauer kmuehlbauer force-pushed the fetch-data branch 2 times, most recently from 0fdfb5e to 0e40737 Compare November 10, 2022 09:34
@kmuehlbauer kmuehlbauer reopened this Nov 10, 2022
@kmuehlbauer
Copy link
Collaborator Author

@mgrover1 Just some maintenance on code and CI.

@mgrover1
Copy link
Collaborator

@kmuehlbauer I think we can go ahead and merge. For some reason code coverage is dropping, but still above 80% which is good!

@kmuehlbauer kmuehlbauer merged commit 596ce94 into openradar:main Nov 11, 2022
@kmuehlbauer kmuehlbauer deleted the fetch-data branch November 11, 2022 14:30
@kmuehlbauer
Copy link
Collaborator Author

@kmuehlbauer I think we can go ahead and merge. For some reason code coverage is dropping, but still above 80% which is good!

There are more lines removed which counted to coverage before than added, so the overall coverage percentage decreased a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants