Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add georeference accessor #60

Merged
merged 8 commits into from Dec 5, 2022

Conversation

mgrover1
Copy link
Collaborator

@mgrover1 mgrover1 commented Dec 2, 2022

Add a georeference accessor which works with dataarrays, datasets, and datatrees.

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #60 (e095877) into main (82a8fe4) will increase coverage by 0.14%.
The diff coverage is 100.00%.

❗ Current head e095877 differs from pull request most recent head 68ade47. Consider uploading reports for the commit 68ade47 to get more accurate results

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   83.29%   83.43%   +0.14%     
==========================================
  Files          17       17              
  Lines        3118     3146      +28     
==========================================
+ Hits         2597     2625      +28     
  Misses        521      521              
Flag Coverage Δ
unittests 83.43% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xradar/accessors.py 68.18% <100.00%> (+29.05%) ⬆️
xradar/georeference/transforms.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mgrover1
Copy link
Collaborator Author

mgrover1 commented Dec 2, 2022

@kmuehlbauer when you get a chance, any feedback here would be greatly appreciated!

Copy link
Collaborator

@kmuehlbauer kmuehlbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgrover1 Great additions for georeferencing. Some minor comments only.

- xmltodict
- pip:
- git+https://github.com/openradar/open-radar-data.git
- git+https://github.com/xarray-contrib/datatree
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming there is bleeding edge code used from datatree, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - I opened an issue over at datatree requesting a new release

xradar/accessors.py Show resolved Hide resolved
xradar/accessors.py Outdated Show resolved Hide resolved
xradar/georeference/transforms.py Outdated Show resolved Hide resolved
@mgrover1
Copy link
Collaborator Author

mgrover1 commented Dec 5, 2022

Thanks for the comments and suggestions @kmuehlbauer - I added in those kwargs to the accessors + datatree transform

@kmuehlbauer
Copy link
Collaborator

@mgrover1 I'm sorry if the recent merges of my other two PR messed up rebase of your branch.

@mgrover1
Copy link
Collaborator Author

mgrover1 commented Dec 5, 2022

@kmuehlbauer no worries!

@mgrover1 mgrover1 merged commit f74952a into openradar:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants