New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add georeference accessor #60
Conversation
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 83.29% 83.43% +0.14%
==========================================
Files 17 17
Lines 3118 3146 +28
==========================================
+ Hits 2597 2625 +28
Misses 521 521
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@kmuehlbauer when you get a chance, any feedback here would be greatly appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgrover1 Great additions for georeferencing. Some minor comments only.
- xmltodict | ||
- pip: | ||
- git+https://github.com/openradar/open-radar-data.git | ||
- git+https://github.com/xarray-contrib/datatree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming there is bleeding edge code used from datatree, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - I opened an issue over at datatree requesting a new release
Thanks for the comments and suggestions @kmuehlbauer - I added in those kwargs to the accessors + datatree transform |
@mgrover1 I'm sorry if the recent merges of my other two PR messed up rebase of your branch. |
@kmuehlbauer no worries! |
Add a georeference accessor which works with dataarrays, datasets, and datatrees.