FIX: furuno backend inconsistencies #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #82 +/- ##
==========================================
- Coverage 87.99% 87.98% -0.02%
==========================================
Files 18 18
Lines 3233 3228 -5
==========================================
- Hits 2845 2840 -5
Misses 388 388
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kmuehlbauer
changed the title
|
I've checked with Alice from GFZ Potsdam. She provided a PPI sweep at -1deg to check the correct raw dtype of the elevation data. Thanks! We are now sure it's |
kmuehlbauer
force-pushed
the
furuno-fillvalue
branch
from
2aaf3f2
to
1bfe9d8
Compare
|
This issue was escalated to Furuno Japan. They already fixed the error in their manuals and updates will be distributed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #77
fixes several issues with the furuno backend