Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: only skip setting cf-attributes if both gain and offset are unused #85

Merged
merged 1 commit into from Feb 9, 2023

Conversation

kmuehlbauer
Copy link
Collaborator

So this is unfortunate, as this slipped through the cracks. But anyway version numbers are cheap. 🤦‍♂️

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #85 (59915eb) into main (cfae676) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   88.00%   87.97%   -0.04%     
==========================================
  Files          18       18              
  Lines        3227     3227              
==========================================
- Hits         2840     2839       -1     
- Misses        387      388       +1     
Flag Coverage Δ
unittests 87.97% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xradar/io/backends/odim.py 88.13% <100.00%> (ø)
xradar/io/backends/iris.py 84.75% <0.00%> (-0.10%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kmuehlbauer kmuehlbauer merged commit ae91496 into openradar:main Feb 9, 2023
@kmuehlbauer kmuehlbauer deleted the fix-odim-cf-attrs branch February 9, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant