New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add spatial_ref
with pyproj
when georeferencing, add/adapt methods/tests
#87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion here - can we call it add_crs
instead of write_crs
? Also, by default, can we call this when "georeference" the data?
@@ -95,6 +98,10 @@ def get_x_y_z(ds, earth_radius=6371000, effective_radius_fraction=None): | |||
.. [1] Doviak and Zrnic, Doppler Radar and Weather Observations, Second | |||
Edition, 1993, p. 21. | |||
""" | |||
if earth_radius is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgrover1 Actually it is written in any case, when georeferenced. So the user doesn't have to do anything, beside georeferencing.
@mgrover1 I've refactored the naming per your suggestion. |
Codecov Report
@@ Coverage Diff @@
## main #87 +/- ##
==========================================
- Coverage 88.00% 87.75% -0.25%
==========================================
Files 18 19 +1
Lines 3227 3284 +57
==========================================
+ Hits 2840 2882 +42
- Misses 387 402 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@mgrover1 I'm ironing out the CI/doc issues. We can let this sit another while. No rush for now to get this in. |
This is the direct link to the docs with a plotting example: |
@mgrover1 Heads-up, I've found some problems with the docs which are slightly related to this PR and I'll add that here. I'll also add some more code to model.py for the sitecoords. |
I've also found an issue that get_x_y_z didn't take the radar site altitude into account, I've fixed this too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
@mgrover1 I'll merge tomorrow, if no-one beats me to it. |
… CI, update requirements (pyproj/cartopy)
…ethods, take site altitude into account, add Locarno MeteoSvizzera site coordinates to model, fix tests, fix docs
dbdd7d7
to
87537e7
Compare
I've rearranged/squashed the commits into two for rebase-merge. Getting this when CI is green. |
This adds
spatial_ref
to the datasets when georeferencing. That way users can easily wrap this into cartopy and use this for georeferenced plotting.