Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: check for dim0 if not given, only swap_dims if needed #94

Merged
merged 3 commits into from Feb 28, 2023

Conversation

kmuehlbauer
Copy link
Collaborator

@kmuehlbauer kmuehlbauer commented Feb 27, 2023

@kmuehlbauer
Copy link
Collaborator Author

I'm still thinking about a proper test for that.

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #94 (18887cc) into main (010b104) will increase coverage by 0.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   87.75%   88.17%   +0.41%     
==========================================
  Files          19       19              
  Lines        3284     3289       +5     
==========================================
+ Hits         2882     2900      +18     
+ Misses        402      389      -13     
Flag Coverage Δ
unittests 88.17% <100.00%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xradar/io/export/cfradial2.py 86.95% <ø> (+52.17%) ⬆️
xradar/model.py 96.17% <100.00%> (+0.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kmuehlbauer
Copy link
Collaborator Author

kmuehlbauer commented Feb 28, 2023

Added cfradial2 roundtrip test and test first_dim in one go. Pulling this in, when CI finished and green.

@kmuehlbauer kmuehlbauer reopened this Feb 28, 2023
@kmuehlbauer
Copy link
Collaborator Author

There has been an issue with ReadTheDocs. I've reported that at RTD and they had a look immediately as it seems. Thanks RTD!

@kmuehlbauer kmuehlbauer merged commit a0a419f into openradar:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Tree can't be exported with to_cfradial2 if time is first dimension
2 participants