Merge pull request #785 from Roeterdink/IncorrectCalculationTrainAhead

Incorrect calculation of distance to train ahead
openrails · Feb 27, 2023 · 9ebd050 · 9ebd050
2 parents eb30a97 + fd121be
commit 9ebd050
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 3 deletions.
diff --git a/Source/Orts.Simulation/Simulation/Signalling/Signals.cs b/Source/Orts.Simulation/Simulation/Signalling/Signals.cs
@@ -3894,7 +3894,7 @@ public void BreakDownRouteList(Train.TCSubpathRoute reqRoute, int firstRouteInde
                             if (considerSpeedReset)
                             {
                                 var speed_infoR = thisSpeedpost.this_sig_speed(SignalFunction.SPEED);
-                                speed_info.speed_reset = speed_infoR.speed_reset;
+                                if (speed_infoR != null) speed_info.speed_reset = speed_infoR.speed_reset;
                             }
                             if ((isFreight && speed_info.speed_freight > 0) || (!isFreight && speed_info.speed_pass > 0) || speed_info.speed_reset == 1)
                             {

diff --git a/Source/Orts.Simulation/Simulation/Signalling/TrackCircuitSection.cs b/Source/Orts.Simulation/Simulation/Signalling/TrackCircuitSection.cs
@@ -1795,8 +1795,35 @@ public bool CheckReserved(Train.TrainRouted thisTrain)
                 }
                 else
                 {
-                    distanceTrainAheadM = offset; // train is off its route - assume full section occupied, offset is deducted later //
-                    trainFound = nextTrain.Train;
+                    distanceTrainAheadM = offset; // train is off its route - check if track occupied by train is ahead or behind us //
+
+                    if (thisTrain != null)
+                    {
+                        int presentFront = thisTrain.PresentPosition[0].RouteListIndex;
+
+                        foreach (TrackCircuitSection occSection in nextTrain.Train.OccupiedTrack)
+                        {
+                            int otherSectionIndex = thisTrain.TCRoute.TCRouteSubpaths[thisTrain.TCRoute.activeSubpath].GetRouteIndex(occSection.Index, 0);
+
+                            // other index is lower - train is behind us
+                            if (otherSectionIndex >= 0 && otherSectionIndex < presentFront)
+                            {
+                                trainFound = null;
+                                continue;
+                            }
+                            // other index is higher - train is in front of us
+                            else if (otherSectionIndex >= 0 && otherSectionIndex > presentFront)
+                            {
+                                trainFound = nextTrain.Train;
+                                continue;
+                            }
+                        }
+                    }
+                    else
+                    {
+                        // else assume ahead of us - assume full section occupied, offset is deducted later //
+                        trainFound = nextTrain.Train;
+                    }
                 }
             }