Remove startup exception in the launcher by refactoring a try-catch #233
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twpol
pushed a commit
that referenced
this pull request
Jul 15, 2020
- Pull request #40 at e81861b: Monogame upgrade - Pull request #79 at 7d9f14b: Update version calculation for new unstable versions - Pull request #216 at 927a49c: Upgrade and replace web server with EmbedIO - Pull request #221 at 13ba17f: Refactor try-catch blocks in RunActivity - Pull request #225 at bb67fb6: Fix advanced adhesion wheelslip upon resuming from save: https://bugs.launchpad.net/or/+bug/1294410 - Pull request #226 at 2ba1d2c: EmbedIO web server graphical track monitor - Pull request #227 at 6ec1539: EmbedIO web server graphical train driving monitor - Pull request #228 at 72c0146: adds links to OR on Elvas Tower - Pull request #233 at 4084c75: Remove startup exception in the launcher by refactoring a try-catch
cjakeman
reviewed
Jul 17, 2020
twpol
pushed a commit
that referenced
this pull request
Jul 20, 2020
- Pull request #40 at e81861b: Monogame upgrade - Pull request #79 at 7d9f14b: Update version calculation for new unstable versions - Pull request #216 at 927a49c: Upgrade and replace web server with EmbedIO - Pull request #226 at 2ba1d2c: EmbedIO web server graphical track monitor - Pull request #227 at 6ec1539: EmbedIO web server graphical train driving monitor - Pull request #228 at 72c0146: adds links to OR on Elvas Tower - Pull request #232 at 377e893: JSON consist format: https://blueprints.launchpad.net/or/+spec/consist-editor - Pull request #233 at 4084c75: Remove startup exception in the launcher by refactoring a try-catch
twpol
pushed a commit
that referenced
this pull request
Jul 21, 2020
- Pull request #40 at e81861b: Monogame upgrade - Pull request #79 at 7d9f14b: Update version calculation for new unstable versions - Pull request #145 at c024d04: Advanced Coupler Functionality - Pull request #216 at 927a49c: Upgrade and replace web server with EmbedIO - Pull request #226 at 2ba1d2c: EmbedIO web server graphical track monitor - Pull request #227 at 6ec1539: EmbedIO web server graphical train driving monitor - Pull request #228 at 72c0146: adds links to OR on Elvas Tower - Pull request #232 at 377e893: JSON consist format: https://blueprints.launchpad.net/or/+spec/consist-editor - Pull request #233 at 4084c75: Remove startup exception in the launcher by refactoring a try-catch
twpol
pushed a commit
that referenced
this pull request
Jul 22, 2020
- Pull request #40 at e81861b: Monogame upgrade - Pull request #79 at 7d9f14b: Update version calculation for new unstable versions - Pull request #216 at 927a49c: Upgrade and replace web server with EmbedIO - Pull request #226 at 2ba1d2c: EmbedIO web server graphical track monitor - Pull request #227 at 6ec1539: EmbedIO web server graphical train driving monitor - Pull request #228 at 72c0146: adds links to OR on Elvas Tower - Pull request #232 at 377e893: JSON consist format: https://blueprints.launchpad.net/or/+spec/consist-editor - Pull request #233 at 4084c75: Remove startup exception in the launcher by refactoring a try-catch - Pull request #234 at e3c545c: Rehabilitate unit testing suite, migrate to xUnit 2
twpol
pushed a commit
that referenced
this pull request
Jul 22, 2020
- Pull request #40 at e81861b: Monogame upgrade - Pull request #79 at 7d9f14b: Update version calculation for new unstable versions - Pull request #216 at 927a49c: Upgrade and replace web server with EmbedIO - Pull request #226 at 2ba1d2c: EmbedIO web server graphical track monitor - Pull request #227 at 6ec1539: EmbedIO web server graphical train driving monitor - Pull request #228 at 72c0146: adds links to OR on Elvas Tower - Pull request #232 at 377e893: JSON consist format: https://blueprints.launchpad.net/or/+spec/consist-editor - Pull request #233 at 4084c75: Remove startup exception in the launcher by refactoring a try-catch - Pull request #234 at 3ac34fe: Rehabilitate unit testing suite, migrate to xUnit 2
twpol
pushed a commit
that referenced
this pull request
Jul 22, 2020
- Pull request #40 at e81861b: Monogame upgrade - Pull request #79 at 7d9f14b: Update version calculation for new unstable versions - Pull request #216 at 927a49c: Upgrade and replace web server with EmbedIO - Pull request #226 at 2ba1d2c: EmbedIO web server graphical track monitor - Pull request #227 at 6ec1539: EmbedIO web server graphical train driving monitor - Pull request #228 at 72c0146: adds links to OR on Elvas Tower - Pull request #232 at 6b464fb: JSON consist format: https://blueprints.launchpad.net/or/+spec/consist-editor - Pull request #233 at 4084c75: Remove startup exception in the launcher by refactoring a try-catch - Pull request #234 at 3ac34fe: Rehabilitate unit testing suite, migrate to xUnit 2
cjakeman
approved these changes
Jul 22, 2020
cjakeman
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code generates a NullReferenceException whenever a locomotive's description is null (i.e., for AI-only equipment). These exceptions interrupt the Visual Studio debugger on startup, making debugging the launcher a rather tedious process with a large content folder.
Bug Report at https://bugs.launchpad.net/or/+bug/1888008