Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct issue with compressor not turning off #515

Merged
merged 1 commit into from Oct 10, 2021

Conversation

peternewell
Copy link
Contributor

@peternewell peternewell added the bug Something isn't working label Oct 8, 2021
@peternewell peternewell self-assigned this Oct 8, 2021
twpol pushed a commit that referenced this pull request Oct 8, 2021
- Pull request #480 at 6bc94a9: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs
- Pull request #503 at 69a70cb: Update derailment functionality
- Pull request #508 at ed80ad6: Blueprint https://blueprints.launchpad.net/or/+spec/odometer-cabview-controls
- Pull request #510 at d4d3256: Add performance monitoring for diesel mechanic locomotives and new parameters
- Pull request #512 at 3aae640: Fixed dynamic brake being applied during standstill when dynamic brake blending is enabled
- Pull request #514 at 8bf4a09: Bug fix for https://bugs.launchpad.net/or/+bug/1946373. The keywords should not be translated.
- Pull request #515 at cd8e29f: Correct issue with compressor not turning off
Copy link
Contributor

@Sharpe49 Sharpe49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.
You need a bug report to merge this fix.
This bug also affects 1.4.

twpol pushed a commit that referenced this pull request Oct 9, 2021
- Pull request #480 at 6bc94a9: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs
- Pull request #503 at 69a70cb: Update derailment functionality
- Pull request #508 at 9d6f01e: Blueprint https://blueprints.launchpad.net/or/+spec/odometer-cabview-controls
- Pull request #510 at d4d3256: Add performance monitoring for diesel mechanic locomotives and new parameters
- Pull request #512 at 3aae640: Fixed dynamic brake being applied during standstill when dynamic brake blending is enabled
- Pull request #514 at 8bf4a09: Bug fix for https://bugs.launchpad.net/or/+bug/1946373. The keywords should not be translated.
- Pull request #515 at cd8e29f: Correct issue with compressor not turning off
Csantucci added a commit to Csantucci/openrails that referenced this pull request Oct 9, 2021
twpol pushed a commit that referenced this pull request Oct 9, 2021
- Pull request #480 at 6bc94a9: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs
- Pull request #503 at a2845f8: Update derailment functionality
- Pull request #508 at 9d6f01e: Blueprint https://blueprints.launchpad.net/or/+spec/odometer-cabview-controls
- Pull request #510 at d4d3256: Add performance monitoring for diesel mechanic locomotives and new parameters
- Pull request #512 at 3aae640: Fixed dynamic brake being applied during standstill when dynamic brake blending is enabled
- Pull request #514 at 8bf4a09: Bug fix for https://bugs.launchpad.net/or/+bug/1946373. The keywords should not be translated.
- Pull request #515 at cd8e29f: Correct issue with compressor not turning off
@peternewell
Copy link
Contributor Author

Seems good to me. You need a bug report to merge this fix. This bug also affects 1.4.

Thanks for that.

Based upon posting, I assume that v1.4 is closed unless it is a major issue.

This is probably more a cosmetic issue I suspect, rather then a major performance issue.

@peternewell peternewell merged commit fab59f5 into openrails:master Oct 10, 2021
@peternewell peternewell deleted the brake-fix#2 branch October 10, 2021 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
2 participants