-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing #526
Conversation
…pears after coupling and reversing
- Pull request #480 at 7815b89: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs - Pull request #510 at 88621d6: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #519 at 94c4637: Website changes for Release v1.4 - Pull request #522 at 78c046c: Correct issue with tender water mass - Pull request #523 at 236aebf: Fix sig_feature function always returning true for SPEED signals - Pull request #525 at 41d74e4: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #526 at 2bfe684: Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing
- Pull request #480 at 7815b89: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs - Pull request #510 at 88621d6: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #519 at 94c4637: Website changes for Release v1.4 - Pull request #522 at 78c046c: Correct issue with tender water mass - Pull request #523 at 236aebf: Fix sig_feature function always returning true for SPEED signals - Pull request #525 at 41d74e4: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #526 at 2bfe684: Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing - Pull request #527 at c786144: Brake cuts power refactor and new parameters
- Pull request #480 at 7815b89: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs - Pull request #510 at 88621d6: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #519 at 94c4637: Website changes for Release v1.4 - Pull request #522 at 78c046c: Correct issue with tender water mass - Pull request #525 at 41d74e4: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #526 at 2bfe684: Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing - Pull request #527 at c786144: Brake cuts power refactor and new parameters - Pull request #528 at 212eba1: Updated link to Siskiyou Route site
- Pull request #480 at 7815b89: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs - Pull request #510 at 1ac4334: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #519 at 94c4637: Website changes for Release v1.4 - Pull request #522 at 78c046c: Correct issue with tender water mass - Pull request #525 at 41d74e4: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #526 at 2bfe684: Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing - Pull request #527 at c786144: Brake cuts power refactor and new parameters - Pull request #528 at 212eba1: Updated link to Siskiyou Route site
- Pull request #480 at 7815b89: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs - Pull request #510 at f25fe0c: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #519 at 94c4637: Website changes for Release v1.4 - Pull request #522 at 78c046c: Correct issue with tender water mass - Pull request #525 at 41d74e4: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #526 at 2bfe684: Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing - Pull request #527 at c786144: Brake cuts power refactor and new parameters - Pull request #528 at 212eba1: Updated link to Siskiyou Route site
- Pull request #480 at 7815b89: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs - Pull request #510 at 906f067: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #519 at 94c4637: Website changes for Release v1.4 - Pull request #522 at 78c046c: Correct issue with tender water mass - Pull request #525 at 41d74e4: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #526 at 2bfe684: Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing - Pull request #527 at c786144: Brake cuts power refactor and new parameters - Pull request #528 at 212eba1: Updated link to Siskiyou Route site
- Pull request #480 at 7815b89: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs - Pull request #510 at 906f067: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #519 at 94c4637: Website changes for Release v1.4 - Pull request #522 at 78c046c: Correct issue with tender water mass - Pull request #525 at 41d74e4: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #526 at 2bfe684: Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing - Pull request #527 at c786144: Brake cuts power refactor and new parameters - Pull request #528 at 212eba1: Updated link to Siskiyou Route site - Pull request #529 at 7848297: Replace manual cover image
- Pull request #480 at 7815b89: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs - Pull request #510 at 7901f4d: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #519 at 94c4637: Website changes for Release v1.4 - Pull request #522 at 78c046c: Correct issue with tender water mass - Pull request #525 at 41d74e4: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #526 at 2bfe684: Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing - Pull request #527 at c786144: Brake cuts power refactor and new parameters - Pull request #528 at 212eba1: Updated link to Siskiyou Route site - Pull request #529 at 7848297: Replace manual cover image
- Pull request #480 at 7815b89: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs - Pull request #510 at 804e9e6: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #519 at 94c4637: Website changes for Release v1.4 - Pull request #522 at 46b388f: Correct issue with tender water mass - Pull request #525 at 41d74e4: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #526 at 2bfe684: Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing - Pull request #527 at c786144: Brake cuts power refactor and new parameters - Pull request #528 at 212eba1: Updated link to Siskiyou Route site - Pull request #529 at 7848297: Replace manual cover image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes seems OK.
But I don't have a test case to check if it works properly.
If you want to test, here http://www.elvastower.com/forums/index.php?/topic/35624-ai-train-disappearing-after-coupling-and-reversing/ you find a test activity. With the actual master release the AI train in the activity will disappear after coupling. With the patch this doesn't occur. |
- Pull request #480 at 7815b89: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs - Pull request #510 at 48f140f: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at 41d74e4: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #526 at 2bfe684: Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing - Pull request #527 at c786144: Brake cuts power refactor and new parameters
- Pull request #480 at 7815b89: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs - Pull request #510 at 39e2370: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at 41d74e4: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #526 at 2bfe684: Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing - Pull request #527 at c786144: Brake cuts power refactor and new parameters
- Pull request #480 at 7815b89: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs - Pull request #510 at eb9bcb7: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at 41d74e4: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #526 at 2bfe684: Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing - Pull request #527 at c786144: Brake cuts power refactor and new parameters
- Pull request #480 at 7815b89: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs - Pull request #510 at eb9bcb7: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at 41d74e4: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #526 at 2bfe684: Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing - Pull request #527 at c786144: Brake cuts power refactor and new parameters - Pull request #530 at 71aa390: Steam adhesion not applied to all locomotives in the player train.
- Pull request #480 at 7815b89: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs - Pull request #510 at e2a54b3: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at 41d74e4: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #526 at 2bfe684: Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing - Pull request #527 at c786144: Brake cuts power refactor and new parameters - Pull request #530 at 71aa390: Steam adhesion not applied to all locomotives in the player train.
- Pull request #480 at 7815b89: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs - Pull request #510 at 35b7c89: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at 41d74e4: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #526 at 2bfe684: Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing - Pull request #527 at c786144: Brake cuts power refactor and new parameters - Pull request #530 at 71aa390: Steam adhesion not applied to all locomotives in the player train.
- Pull request #480 at 7815b89: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs - Pull request #510 at 35b7c89: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at 41d74e4: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #526 at 2bfe684: Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing - Pull request #527 at c786144: Brake cuts power refactor and new parameters - Pull request #530 at 71aa390: Steam adhesion not applied to all locomotives in the player train. - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab
- Pull request #480 at 7815b89: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs - Pull request #510 at 9e21c68: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at 41d74e4: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #526 at 2bfe684: Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing - Pull request #527 at c786144: Brake cuts power refactor and new parameters - Pull request #530 at 71aa390: Steam adhesion not applied to all locomotives in the player train. - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab
- Pull request #480 at 7815b89: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs - Pull request #510 at 9e21c68: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at 41d74e4: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #526 at 2bfe684: Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing - Pull request #527 at c786144: Brake cuts power refactor and new parameters - Pull request #530 at ea547da: Steam adhesion not applied to all locomotives in the player train. - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab
- Pull request #480 at 7815b89: Blueprint https://blueprints.launchpad.net/or/+spec/digital-alignment-in-3dcabs - Pull request #510 at 2e03d42: Add performance monitoring for diesel mechanic locomotives and new parameters - Pull request #525 at 41d74e4: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #526 at 2bfe684: Bug fix for https://bugs.launchpad.net/or/+bug/1949292 AI train disappears after coupling and reversing - Pull request #527 at c786144: Brake cuts power refactor and new parameters - Pull request #530 at ea547da: Steam adhesion not applied to all locomotives in the player train. - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab
Thanks for approval. |
The fix follows the same lines used for the player train