Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to DI func<> tests so they can be reused like previous DI tests #140

Merged
merged 2 commits into from
Mar 31, 2018

Conversation

holytshirt
Copy link
Member

The Windsor DI was missing all the new Func<> tests.
I've done the working in the windsor DI to support func<> openrasta/openrasta-castle-windsor@db2431f
And have made the testing in OR shareable with Windsor DI project.

The only "real" code change I had to make was the second commit which changes 2 class to public. If you don't Windsor throws and error

Attempt by method 'Castle.Proxies.Func`1Proxy.Invoke()' to access type 'System.Collections.Generic.IEnumerable`1 failed. at Castle.Proxies.Func`1Proxy.Invoke()

It does not seem to be able to access the method if the classes are not public.

  • the code
  • If it's a non-trivial piece of code, signing a CLA
  • If it breaks, change, fix or add to existing behaviour, updating
    CHANGELOG.md
  • [x ] If it's a bug fix, tests in the Tests project, or scenarios in the TestRig.
  • On top of HEAD, unless it's a bugfix on a previous version
  • VERSION file updated if not creating a pull-request on top of master

@serialseb serialseb merged commit 243d139 into master Mar 31, 2018
@serialseb serialseb deleted the di-test-changes branch March 31, 2018 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants