Update project format and packaging #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holytshirt
force-pushed
the
update-packaging
branch
5 times, most recently
from
904afda
to
66562e4
Compare
serialseb
reviewed
Oct 1, 2021
|
While we're doing a bit of upkeep and maintenance, would it be worth getting rid of unsupported net46 builds if they're EOL? |
@serialseb okay I'll push to net472, better compatibility with .netstandard2.0 |
- Start moving to github actions for build, test, package - Have to use windows images at the moment till I work out which tests are windows only - Make sure configuration is set to release - Make sure fetch depth is set to 0 so minver can get the last version tag
- Add test-reporter github action https://github.com/dorny/test-reporter
- Create Directory.Build.props for shared project properties - Update how nuget package icons are done - Add PackageLicenseExpression MIT - Add SourceLinking - Move versioning to Directory.Build.props - Add MinVer for package versioning based on tag + height - Create nuget packages as part of build
- Removed AllowedOutputExtensionsInPackageBuildOutputFolder no longer recommended since nuget has its own symbol server https://github.com/dotnet/sourcelink#alternative-pdb-distribution - Added DebugType Embedded & ContinousIntergrationBuild as recommended https://devblogs.microsoft.com/dotnet/producing-packages-with-source-link/
holytshirt
force-pushed
the
update-packaging
branch
from
8a7bbae
to
5567459
Compare
|
@serialseb This is ready now, includes updating to net6, package updates, build done by github actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Thank you so much for contributing this pull request. We love when the community
steps up and share, and we're enormously thankful.
You don't have to do all of those following things, they are what we try and get
done for code coming in:
CHANGELOG.md
project, or scenarios in theTestRig.masterIf those are needed, and you haven't and can't, we thank you enormously for your
contribution, and we'll add those before merging the pull request.
Thanks!
The OpenRasta community