-
-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DONOTMERGE: add static reset command to have a ripple effect with a static low light #1758
base: master
Are you sure you want to change the base?
Conversation
Hey @nicman23, I've just tested this on my RGB keyboard and it works well. If I have some spare time I'll look at updating the code further so the color can be selected from Polychromatic. |
great ! what i am not sure after thinking about it is if the static_reset function should be on the ripple effect file or in the same place that reset_rows is |
That's a good point, but since the ripple colour is passed in here it's probably the right place. Just need to link it all together with the API, but haven't looked that far yet.
On 23 February 2022 11:24:01 pm AEDT, nicman23 ***@***.***> wrote:
great ! what i am not sure after thinking about it is if the static_reset function should be on the ripple effect file or in the same place that reset_rows is
--
Reply to this email directly or view it on GitHub:
#1758 (comment)
You are receiving this because you commented.
Message ID: ***@***.***>
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
is there any interest on this? i d like to mainstream it |
Thanks for this! Not having a static "background" color on effects like ripple and reactive has been my biggest issue with my setup, so I would love to see this added. For now, I've copied your changes and will play around to see what I can tweak for myself. |
Hi. Was this ever addressed? I have multiple color keyboard (BlackWidow V3) and I'm looking at this code to implement this for the ripple effect. I feel like it'd be a great addition. If not for the main project at least as some sort of external script |
I have addressed the multiple color issue with this code. Works well with Polychromatic, didn't test anything else. Admittedly, I barely read through the code and it's quite possible this requires a lot more work to ensure it does not break things, but it's good enough for me. |
Mostly a pull request to see if anyone else is interested to work with me on this because i have a green only blackwidow.
as a result the commit assumes my set up and has a hard coded self.low_colour and also a bumped refresh because it was a bit slow for my liking.