-
-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Razer Pro Type Ultra keyboard #2136
base: master
Are you sure you want to change the base?
Conversation
40cdcdb
to
fafb338
Compare
fafb338
to
ef3e1ff
Compare
|
||
USB_VID = 0x1532 | ||
USB_PID = 0x0277 | ||
METHODS = ['get_device_type_keyboard', 'set_static_effect', 'set_breath_single_effect', 'get_battery', 'is_charging', 'get_keyboard_layout'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The device really doesn't support more effects than this? At least set_none_effect
maybe to turn off the lighting? Or brightness controls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have usb packet captures from Razer Synapse on Windows for this device maybe? Would be great if I could have a look at them. |
Wired capture:
Wireless capture:
|
report.arguments[4] = 0x01; | ||
report.arguments[5] = 0x01; | ||
report.arguments[6] = brightness; | ||
return report; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced making a custom function for this device is necessary.
The razer_chroma_extended_matrix_effect_static
function doesn't work for this device? In the pcap I see rgb=0xFFFFFF there except that report.argument[4] = 0x01
, everything else looks to be the same.
Same with breathing effect.
CREATE_DEVICE_FILE(&hdev->dev, &dev_attr_matrix_effect_breath); // Breathing effect | ||
CREATE_DEVICE_FILE(&hdev->dev, &dev_attr_charge_level); // Battery charge level | ||
CREATE_DEVICE_FILE(&hdev->dev, &dev_attr_charge_status); // Battery charge status | ||
break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You patch the brightness function above but don't actually add it to the device?
is there anything missing before its merged? i have that keyboard and would love to have this fully supported :) |
@damnms There are some outstanding comments. If you can address them yourself, please feel free to work on them and open a new PR if the original author here is not active anymore. |
i am no dev so i can unfortunately not answer those. but if you need a dump of packages, i guess i could provide them. if you maybe can help me a bit in providing them, what i need or what i should execute, i can do that. |
Add support for Razer Pro Type Ultra wired and wireless.
Notes:
Fixes #1776