Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Razer Blade 14 (2024) #2241

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Conversation

jetoile
Copy link

@jetoile jetoile commented Apr 28, 2024

Changes based on #2237 .

Add support for new razer blade 14 (2024)

lsusb | grep '1532:'
Bus 001 Device 003: ID 1532:02b6 Razer USA, Ltd Razer Blade

Everything seems to work fine at least on my laptop (ubuntu 24.04)

Fixes #2242

driver/razerkbd_driver.h Outdated Show resolved Hide resolved
@z3ntu
Copy link
Member

z3ntu commented Apr 28, 2024

Could you do me a favor and fill out the issue template for this device also? https://github.com/openrazer/openrazer/blob/master/.github/ISSUE_TEMPLATE/new-device-support.md?plain=1 Ignore packet captures & Synapse screenshots parts, those are not relevant now, so just the first two sections.

@jetoile
Copy link
Author

jetoile commented Apr 28, 2024

Could you do me a favor and fill out the issue template for this device also? https://github.com/openrazer/openrazer/blob/master/.github/ISSUE_TEMPLATE/new-device-support.md?plain=1 Ignore packet captures & Synapse screenshots parts, those are not relevant now, so just the first two sections.

here it is : #2242

@z3ntu
Copy link
Member

z3ntu commented Apr 29, 2024

Thanks!

From #2242 (comment):

Also, the options include an option for "Logo Lighting" despite the device having no logo to illuminate.

@kopax-polyconseil
Copy link

Wow, that's awesome. Do you manage to run all device such as sounds, microphone, integrated webcam or bluetooth ?

Will this work with Debian or Ubuntu ?

What are we waiting for :) ?

@Ardemium
Copy link

Ardemium commented Jun 17, 2024

Status update please, why is this pr not yet merged?

@lixulplick
Copy link

Curious, any update on when this will be available?

@Ardemium
Copy link

I have performed a review, and everything seems correct and adheres to the conventions. Is there anything further I can do to assist with this feature?

@lixulplick
Copy link

Hey all, any idea when this will be merged and available? Thanks!

@z3ntu
Copy link
Member

z3ntu commented Jul 2, 2024

@jetoile (or someone else) Can you confirm whether this laptop has a logo led to control or not? See #2241 (comment)

Once that's resolved I think we can merge.

@LabyStudio
Copy link

@jetoile (or someone else) Can you confirm whether this laptop has a logo led to control or not? See #2241 (comment)

Once that's resolved I think we can merge.

There is a logo led yes

@z3ntu
Copy link
Member

z3ntu commented Jul 2, 2024

Rebased the PR on master.

@LabyStudio Is the logo led control functional from openrazer, so can you change the logo on/off via polychromatic or RazerGenie when you have the branch installed? I'd like to have this confirmed before merge actually, since I've heard on several Blades this was never tested so the functionality was not working then.

@jetoile
Copy link
Author

jetoile commented Jul 2, 2024

Rebased the PR on master.

@LabyStudio Is the logo led control functional from openrazer, so can you change the logo on/off via polychromatic or RazerGenie when you have the branch installed? I'd like to have this confirmed before merge actually, since I've heard on several Blades this was never tested so the functionality was not working then.

Hello z3ntu,

First of all, thanks for the follow up and the rebase (and sorry for the delay).
From my laptop with ubuntu 24.04, I can confirm that the logo on/off is working fine with polychromatic.

@fallenpixel
Copy link

Does the black model have logo lighting? I bought the mercury white edition and it does not.

@fallout2886
Copy link

Does the black model have logo lighting? I bought the mercury white edition and it does not.

Yes, only the black edition has got a logo led. One reason I bought the mercury one.

@fallenpixel
Copy link

Does the black model have logo lighting? I bought the mercury white edition and it does not.

Yes, only the black edition has got a logo led. One reason I bought the mercury one.

That takes away all my concern then. I don't think there's a way to distinguish between the colorways from the USB ID.

@z3ntu
Copy link
Member

z3ntu commented Jul 6, 2024

There's probably some way to figure out from software if it's a mercury/black model, but correct, not from USB ID it seems which is what we use exclusively to distinguish devices.

Let's keep the LED control then, and let it be non-functional on mercury ones.

Copy link
Member

@z3ntu z3ntu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution!

@z3ntu z3ntu merged commit 0a00e1e into openrazer:master Jul 6, 2024
2 checks passed
@lixulplick
Copy link

Thanks all! Looking forward to trying this out from Master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Support for Razer Blade 14 (2024)
8 participants