Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CORS headers to Mock API #34

Closed
bzurkowski opened this issue Jun 24, 2020 · 1 comment
Closed

Add CORS headers to Mock API #34

bzurkowski opened this issue Jun 24, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@bzurkowski
Copy link
Member

bzurkowski commented Jun 24, 2020

According to the solution proposed in #20 (review), we should allow all CORS origins in OpenRCA API to enable seamless communication from the UI. The Flask server should be configured with a proper CORS policy. Consider using a plugin such as Flask-CORS or try to modify the headers manually.

First, let's test the fix in the Mock API. Second, we will apply a similar patch to the core repository.

Some useful materials:

@bzurkowski bzurkowski added the enhancement New feature or request label Jun 24, 2020
aleksandra-galara added a commit to aleksandra-galara/orca-ui that referenced this issue Jun 30, 2020
It implements (openrca#34)

Signed-off-by: Aleksandra Galara <a.galara@samsung.com>
@bzurkowski
Copy link
Member Author

Closed by #41.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants