Handymen cut grass incorrectly

[Krutonium]

OS: [Arch Linux
Version: 0.2.4-95
Commit/Build: 40e22eb

Handymen cut the grass one way, and the cut grass is rendered in a way that indicates they mowed in a different direction

• Reproducible in RCT2 (vanilla)?
• Specific to multiplayer?

Steps to reproduce:

1. Place Handyman on uncut grass
2. Allow him to cut grass

Dump file

Screenshots / Video:

Save game:

[tupaschoal]

Behavior on:

• OpenRCT2/OpenRCT2@073e4b0cc: https://i.imgur.com/7Wy9Qow.gif
• OpenRCT2/OpenRCT2@1f3998909 (which is 0.2.3): https://i.imgur.com/qad5MBE.gif
• OpenRCT2/OpenRCT2@40e22eba8 (0.2.4): https://i.imgur.com/hlZNSAM.gif
• OpenRCT2/OpenRCT2@966ba6b01 (tip): https://i.imgur.com/3UKZBC9.gif

It seems to be working fine, since August. In fact I even built with the first commit of the year, which was still in version 0.2.1. I didn't see the off by one cutting and the mowing seemed to always have been the same thing.

[Gymnasiast]

@tupaschoal All of the GIFs you posted are showing the handyman moving in the wrong direction, though. He is mowing lanes from bottom-left to top-right, while the lanes that appears are from top-left to bottom-right, so rotated by 90°.

[tupaschoal]

Yes, that I noticed, but I went as far as January 1st, 2019 and still saw the exact same behavior, so I started wondering whether it had always been a bug

[Gymnasiast]

Oh, some bugs have been in the game for years. Some are even the result of a typo that was made during initial implementation. Still a bug, though.

[tupaschoal]

Yup, I started Vanilla and saw the behavior was different P

[tupaschoal]

I can add a gif later today, but basically I loaded the same save used for the gifs above and vanilla RCT2 has the sprites in the exact orientation as the handyman is cutting.

[duncanspumpkin]

I just removing all the discussion about it being a vanilla bug as we have established that it is not a vanilla bug and is a mistake that has been around for a while.

[duncanspumpkin]

It seems to be a display issue caused by Terrain Surface objects refactor.

On the left is RCT2 vanilla on the right OpenRCT2.

[duncanspumpkin]

Looks to be a bug in our object. Unfortunately CS layed out the images in an odd order. It goes:

rotation	base_image	old_set
0	0xA8D	2
1	0xA67	0
2	0xA8D	2
3	0xA67	0

In our object format we have the following:

rotation	new_set
0	3
1	5
2	3
3	5

Where a new_set is converted into the old set by taking away 3.

So all we need to do to fix it is reorder the special section in our object for terrain_surface.