Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or Expose gMapBaseZ #21379

Closed
duncanspumpkin opened this issue Feb 11, 2024 · 1 comment
Closed

Remove or Expose gMapBaseZ #21379

duncanspumpkin opened this issue Feb 11, 2024 · 1 comment
Labels
discussion Some input from team members is wanted.

Comments

@duncanspumpkin
Copy link
Contributor

#21370 moved gMapBaseZ into the gamestate structure. But nothing ever sets this to a value other than 7 (except possibly from an s6 file). This issue is to discuss if we should either:

  1. Change it to a constant 7 or
  2. Expose it in the Ui so users can modify it.

What does gMapBaseZ do:

It controls which land height counts as 0 metres/feet. This can be seen when viewing height labels and watching the altitude graph for a roller coaster. Purely cosmetic.

@duncanspumpkin duncanspumpkin added the discussion Some input from team members is wanted. label Feb 11, 2024
@Gymnasiast
Copy link
Member

Having given it some thought, I can agree to removing it. A constant would do the job well, and the feature isn’t that useful. Our codebase is big enough already.

ThatzOkay added a commit to ThatzOkay/OpenRCT2 that referenced this issue Feb 20, 2024
Close OpenRCT2#21379: Move map base z to constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Some input from team members is wanted.
Projects
None yet
Development

No branches or pull requests

2 participants