Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation: Separate objective date string from staff tenure date string #22072

Open
groenroos opened this issue May 20, 2024 · 0 comments · May be fixed by #22074
Open

Localisation: Separate objective date string from staff tenure date string #22072

groenroos opened this issue May 20, 2024 · 0 comments · May be fixed by #22074

Comments

@groenroos
Copy link

The string STR_2736 ({MONTH}, Year {COMMA16}) is used both for scenario objectives as part of e.g. STR_2386 (e.g. To have at least 800 guests in your park at the end of October, Year 2), as well as staff tenure on the staff member details panel as part of STR_2350 (e.g. Employed: March, Year 1).

In agglutinative languages such as fi_FI (and others), there's no natural-sounding way to use the same STR_2736 for both interpolating in the middle of a sentence, as well as displaying it as the value of a label-value pair.

Similar to the problems in #14594 and #15452, in these types of languages, the preposition would need to attach to the end of each of the words within the sub-string:

Have at least 800 guests your park-in October-of, Year-of 2 the end-at

But if the translation bakes this grammar into STR_2736, it then looks improper in the staff information panel:

Employed: March-of, Year-of 1

Solution: Duplicate STR_2736 so that there are two identical {MONTHYEAR} formatting strings in each language file; one would be used only as part of interpolating into sentences, such as the scenario objectives (STR_2386, STR_2387), and the second one would be used only as part of label-value pair, such as the staff information panel (STR_2350). While for most languages these would probably remain identical, for agglutinative languages this would allow for the required context-sensitive grammar.

mrmagic2020 added a commit to mrmagic2020/OpenRCT2 that referenced this issue May 21, 2024
mrmagic2020 added a commit to mrmagic2020/OpenRCT2 that referenced this issue May 27, 2024
mrmagic2020 added a commit to mrmagic2020/OpenRCT2 that referenced this issue Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant