Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: Upgrade all requirements #258

Merged
merged 1 commit into from
Oct 6, 2021
Merged

requirements: Upgrade all requirements #258

merged 1 commit into from
Oct 6, 2021

Conversation

odscjames
Copy link
Contributor

Had to move to html_js_files - add_javascript was deprecated in 1.8!

Had to move to html_js_files - add_javascript was deprecated in 1.8!
@odscjames odscjames self-assigned this Oct 5, 2021
@odscjames
Copy link
Contributor Author

This can be seen at http://docs.openreferral.org/en/upgrade-all/

@@ -6,7 +6,8 @@ Sphinx
docutils>=0.16,<0.17
sphinx-intl
transifex-client
sphinx-rtd-theme
# Keep to version 0.5 at the moment because the next version (1.0) has some breaking changes to the navigation menu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've approved this @odscjames , but I'd like to know what these changes are / look like, as they may be useful!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The + and - things in the side menu break, and are just shown as a button with no label. It's an odd one because I'm pretty sure we haven't changed anything to do with those, but then v1.0 was only out a few weeks back. I'll open a issue so this knowledge is not lost.

@odscjames odscjames merged commit 13b04a4 into master Oct 6, 2021
@odscjames odscjames deleted the upgrade-all branch October 6, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants