Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiles documentation #446

Merged
merged 12 commits into from Aug 24, 2023
Merged

Profiles documentation #446

merged 12 commits into from Aug 24, 2023

Conversation

mrshll1001
Copy link
Contributor

@mrshll1001 mrshll1001 commented Aug 4, 2023

This PR changes the existing Variations and Interoperability Page to "Profiles, Variations, and Interoperability" as a first step in both documenting the Profiles mechanism and reorganising some documentation.

@greggish has already reviewed, with some copy-edits having been integrated via #445, and I've responded to some sentence structure errors kindly highlighted by a member of the community as well.

I'm intending to flag this PR in a forum post to the community, and then ideally we can get this merged to go live sometime next week.

Have tagged some potential reviewers but depending on availability we likely can go ahead with the merge unless a community member flags something concerning.

@mrshll1001 mrshll1001 self-assigned this Aug 4, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if a bullet-point list of things a profiles allows you do could be useful?

Profiles may declare new optional or mandatory fields, make existing optional fields mandatory, introduce new validation rules or new structures, or declare new API endpoints in addition to those on the HSDS API Reference.

Conversely, Profiles may also remove or override some parts of the HSDS Schema which are not relevant to them. (This will not prevent a publisher from publishing such excluded data, but it may not be validated by tooling used by that Profile, as it is technically additional data from the Profile's perspective.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've restructured as a bullet point list. It might need a bit of word-smithing, but I agree seeing a bulleted list of what a profile can do is generally more readable/accessible than having this information in a series of paragraphs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speaking to people who have implemented other HSDS Profiles may help you with thinking through some aspects of Profiles.

Not sure about the end of this sentence.

@dan-odsc - Reminder to self to propose re-worded version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've refactored to read:

Speaking to people who have implemented other HSDS Profiles may help you with thinking through common challenges when developing a new Profile.

Copy link
Contributor

@dan-odsc dan-odsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have edited some typos and left some comments for now.

@dan-odsc dan-odsc merged commit 13ec70f into 3.0 Aug 24, 2023
8 of 11 checks passed
@dan-odsc dan-odsc deleted the profiles-documentation branch August 24, 2023 08:56
@mrshll1001 mrshll1001 mentioned this pull request Sep 14, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants