Recon dialog: suggested types should be clickable (missing <label> DOM element)

[wetneb]

In the recon dialog, the suggested types are not clickable: one needs to click the radio button next to them.
This is bad accessibility.

Proposed solution

Enclose the type name and id in a <label> element associated to the radio button, so that one can click on the text as well.

Alternatives considered

none

Additional context

[chelseaqnguyen]

hi! can i work on this?

[Redeem-Grimm-Satoshi]

@wetneb Is this issue still available? since @chelseaqnguyen haven't sent a PR yet

[wetneb]

Sure, go ahead!

[itxsoumya]

hey @wetneb could you plz assign this issue to me

[Redeem-Grimm-Satoshi]

@wetneb I can't seem to find the directory where the items in the column are rendered on the Standard Service Panel as show below;

Did I miss something?

[wetneb]

Have you tried this? https://openrefine.org/docs/technical-reference/code-contributions#locating-the-relevant-part-of-the-code-to-change

If so, which strings did you search for?

[Redeem-Grimm-Satoshi]

Yes @wetneb, Thanks for the feedback!

Searched "Reconcile each cell to an entity of one of these types" and "core-recon/cell-type",
Which got me to standard-service-panel.js and standard-service-panel.html

Still didn't find I wanted.. Currently looking into it

[tfmorris]

The list of items comes from the backend reconciliation service based on the data sent to it from the column being reconciled. The example above seems to be from the Wikidata reconciliation service.

[wetneb]

Nicely done @Redeem-Grimm-Satoshi, you found the correct file: standard-service-panel.js.
This is indeed where the suggested types are rendered. Perhaps search for "type" in that file?

[Redeem-Grimm-Satoshi]

Yes @wetneb , located the 'type'

[Redeem-Grimm-Satoshi]

@wetneb Sent in a PR

[Redeem-Grimm-Satoshi]

How it works;

recon.mp4