This repository has been archived by the owner on Mar 15, 2021. It is now read-only.
Specify instance image via aws_ami resource #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit specifies the instance image via the aws_ami resource.
This has the following advantages:
- it makes it clearer which ami we're using, and what specific
properties we want (in this case, ubuntu xenial on hvm with ssd
storage)
- it will automatically use newer AMIs when they become available
This has the following disadvantage:
- it will automatically use newer AMIs when they become available
ie, when a new ubuntu AMI gets baked, this code will automatically
rebuild the world to use it.
Putting this out as a PR for discussion; I'm undecided about it.
|
Worth mentioning that this PR, at the moment, results in a plan which does no changes. Which is as expected 😄 |
samcrang
approved these changes
Feb 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit specifies the instance image via the aws_ami resource.
This has the following advantages:
properties we want (in this case, ubuntu xenial on hvm with ssd
storage)
This has the following disadvantage:
ie, when a new ubuntu AMI gets baked, this code will automatically
rebuild the world to use it.
Putting this out as a PR for discussion; I'm undecided about it.