This repository has been archived by the owner on Jan 4, 2018. It is now read-only.
Fix primary key assumption #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can remove this hack if we make the functional tests supply a Host header which the ResourceBase class can inspect. As part of this, I changed `ft_test_pkey` to `ft-test-pkey` as underscores aren't normally allowed in hostnames.
Previously, a host of school.beta.openregister.org would cause the register to think the primary key was `school.beta`. After this commit, it thinks it is `school`.
We don't need to construct the whole request URL in order to extract the Host (and handle the resulting exceptions from the URI constructor) when we can just fetch the Host header directly.
After the changes to ResourceBase, this test was broken.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a host of school.beta.openregister.org would cause the
register to think the primary key was
school.beta. After this commit,it thinks it is
school.