This repository has been archived by the owner on Mar 24, 2019. It is now read-only.
New data model #62
Closed
New data model #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version hash should include information about the parent of the version. The initial version only needs to be inserted if the table is empty.
Turns out this is exactly the same as save. Convenient!
Using a LEFT JOIN caused toOptionalRecord to blow up with a NullPointerException, because it causes the query to return rows with nulls. INNER JOIN instead causes the query to return 0 rows if the lateral select doesn't find anything.
Finding by record hash in this new data model doesn't fit very well -- it seems a better fit to find by version hash + primary key. This will also make it easier to find previous versions of a record.
philandstuff
force-pushed
the
new-data-model
branch
from
26de84e
to
de696ee
Compare
|
closing this as it's served its educational purpose. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't ready for merging yet, I'm just raising a PR to show my working.
All the tests pass but I haven't implemented the "previous versions" functionality, and the findByKV method only works for the primary key field.
The
/hash/<record-hash>route doesn't fit the new data model very well because it no longer uniquely identifies a single version of a record, so I've added a/version/<version-hash>/<record-primary-key>route to identify a specific version of a record. I also don't do anything with the SortBy parameters so that will need to be fixed too.I'll talk about this at standup on monday.