Skip to content
This repository has been archived by the owner on Mar 15, 2021. It is now read-only.

Makes register download / API options more prominent #518

Merged
merged 9 commits into from Dec 7, 2018

Conversation

injms
Copy link
Contributor

@injms injms commented Dec 3, 2018

Context

Getting access to a Register's data means a user needs to choose whether they want to download the data or use the API. This choice was the second step in the flow - but surfacing the choice sooner highlights the different methods offered and removes a step in the process.

The card has the prototype and the content documents attached to it.

Changes proposed in this pull request

  • Removes the 'Choose access' step
  • Adds API and download options onto register page
  • Removes custom form header styles
  • Replaces old highlight boxes styles with new
  • Small amount of refactoring, removing old Elements and adding new Design System
  • Rewrote tests to take into account new flow

Guidance to review

  • Look out for anything else that could be removed
  • Layout uses display: flex, so falls back to floats for Internet Explorer 8 to 10

@injms injms added the do not merge Don't merge this branch until the person raising pull request has removed the label. label Dec 3, 2018
@injms injms changed the title Makes download / API more prominent Makes register download / API options more prominent Dec 3, 2018
Copy link
Contributor

@gidsg gidsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (aside from minor comment) 👍 🍎

@injms injms merged commit 0e0993f into master Dec 7, 2018
@injms injms deleted the surfacing-download-and-api branch December 7, 2018 10:22
@injms injms removed the do not merge Don't merge this branch until the person raising pull request has removed the label. label Dec 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants