-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable retry in balancer_by_lua_block: need to set proxy_next_upstream_tries #90
Comments
@fongx Will you try the latest master branch of lua-nginx-module? |
I have the issue in the latest release openresty-1.11.2.2.tar.gz of lua-nginx-module but not test the latest master branch. Do you have merged any changes for this to the master branch since v1.11.2.2? PS: sorry for the close and reopen by a mistaken click |
@fongx IIRC, there is a related fix in the master. Why don't you try it out and/or check out the commit log history? |
I checkout the latest master and install it on a new machine. But it's weired, the problem seems unresolved. Yes, I find the patch have been applied at 853. Maybe I still miss something else. I will check more and then come back. |
BINGO. It's fixed in the latest master branch. Thanks. |
hello, I find, in order to enable the retry, it needs to explicitly set the proxy_next_upstream_tries directive to a value greater than the default value, zero. I think it's a bug or at least it's incompatible with the original upstream failover policy. Because the document says the default zero value indicates that nginx won't limit the retry times other than disable the retry. If it's by design, its better to make it clearly in the document.
The text was updated successfully, but these errors were encountered: