added the fifth param for ngx.re.find() #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lancelijade This looks generally good except that I'd rename the "n" parameter to "nth" to be a bit clearer :) Also, we need to port this "nth" argument support to the ngx_lua core's ngx.re.find implementation too :) |
|
I'm tried to modify ngx_http_lua_regex.c , but cannot correctly added the fifth argument to that function. :( |
|
Heh, that is an evidence for the better hackability of the new FFI-based API in lua-resty-core ;) No worries. I can take care of that :) |
agentzh
added a commit
to openresty/lua-nginx-module
that referenced
this pull request
Nov 26, 2013
… control which submatch capture's indexes are returned. thanks Lance Li for the feature request in openresty/lua-resty-core#1.
agentzh
added a commit
that referenced
this pull request
Nov 27, 2013
…nce Li for the original patch in #1.
|
Already applied a modified version of your patch to master. Also added the corresponding support to the ngx_lua core. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to retrieve the n-th matched result's position