bugfix: fixed a segfault when unsinking 64-bit pointers. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unsinking code was not using the correct layout for GC64 IR constants (value in adjacent slot) for this case. This patch is a derivative of raptorjit/raptorjit#246 ported for LuaJIT itself. Fixed after an intense debugging session with @lukego. Co-authored-by: Luke Gorrie <lukego@gmail.com>
thibaultcha
force-pushed
the
fix/unsink-64-ptr
branch
from
3363958
to
1a8c006
Compare
|
@thibaultcha Have you guys submitted the patch to the luajit mailing list? Didn't see it the last time I checked. |
|
Ah, this is a good catch. And should be safe to merge. Many thanks for digging it! |
agentzh
approved these changes
Mar 25, 2019
thibaultcha
added a commit
to openresty/lua-resty-core
that referenced
this pull request
Mar 29, 2019
…round a bug in LuaJIT's allocation sinking optimizer which might lead to NULL cdata pointers and segfaults." This reverts commit c99fbaf following the LuaJIT at openresty/luajit2#46.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unsinking code was not using the correct layout for GC64 IR constants (value in adjacent slot) for this case. This patch is a derivative of raptorjit/raptorjit#246 ported for LuaJIT itself. Fixed after an intense debugging session with @lukego.
Also included in this PR: a matrix of XCFLAGS on Travis-CI, to which we added non Lua 5.2 and GC64 modes.
Sister PR with test: openresty/luajit2-test-suite#6
Fixes the issue initially reported at: openresty/lua-resty-core#232