[aarch64] Fix crash with side traces under register pressure #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IRRefs that get into the side trace from the parent trace may restore REF_BASE under register pressure and get to head_side holding on to it. Restore such references so that REF_BASE gets RID_BASE back in head_side.
|
Merged. Thanks. |
|
Just for the record, this bug led to random crashes when fuzzing our edgelang and ylang compilers on aarch64. And random seed numbers had to be used to feed the API function jit.prngstate to reproduce this more frequently. And this work was sponsored by OpenResty Inc :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRRefs that get into the side trace from the parent trace may restore
REF_BASE under register pressure and get to head_side holding on to
it. Restore such references so that REF_BASE gets RID_BASE back in
head_side.